feat: support statefulSets #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Duologic looks really nice! cat test_data/sample-app.yaml | go run ./cmd/helmify examples/app |
arttor
requested changes
Mar 23, 2022
| @@ -0,0 +1,138 @@ | |||
| package statefulset | |||
There was a problem hiding this comment.
Please add statefulset sample to test_data/sample-app.yaml
And regenerate examples in /examples directory by running:
cat test_data/sample-app.yaml | go run ./cmd/helmify examples/app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for StatefulSets, which is pretty much the same as Deployments.
To facilitate this I've abstracted out the processing of Deployment into logical functions
so that both the StatefulSet and Deployment can use them.
I've also hitched a small feature along with this change: templating Args into Values.